How does amc define 'better version'?

Running FileBot from the console, Groovy / FileBot scripting, shell scripts, etc
Post Reply
tatar0900
Posts: 12
Joined: 10 Oct 2017, 11:17

How does amc define 'better version'?

Post by tatar0900 » 10 Mar 2019, 19:34

Hi rednoah
my post processing script has

Code: Select all

--conflict auto
But as per the log and observation

Code: Select all

Run script [fn:amc] at [Sun Mar 10 20:12:24 CET 2019]
Parameter: unsorted = y
Parameter: music = n
Parameter: artwork = y
Parameter: excludeList = .excludes
Parameter: ut_dir = /home/someUser/torrents/deluge/Magnificent.Movie.2018.INTERNAL.1080p.BluRay.X264-AMIABLE
Parameter: ut_kind = multi
Parameter: ut_title = Magnificent.Movie.2018.INTERNAL.1080p.BluRay.X264-AMIABLE
Parameter: ut_label = N/A
Parameter: exec = chmod -R 775 /home/someUser/torrents/deluge/
Use excludes: /home/someUser/torrents/deluge/plex/.excludes (2857)
Read archive [Magnificent.engines.2018.internal.1080p.bluray.x264-amiable.rar] and extract to [/home/someUser/torr
ents/deluge/Magnificent.Movie.2018.INTERNAL.1080p.BluRay.X264-AMIABLE/Magnificent.engines.2018.internal.1080p.bluray.x
264-amiable/Magnificent.Movie.2018.INTERNAL.1080p.BluRay.X264-AMIABLE]
Extracting files [/home/someUser/torrents/deluge/Magnificent.Movie.2018.INTERNAL.1080p.BluRay.X264-AMIABLE/morta
l.engines.2018.internal.1080p.bluray.x264-amiable/Magnificent.Movie.2018.INTERNAL.1080p.BluRay.X264-AMIABLE/Morta
l.Movie.2018.INTERNAL.1080p.BluRay.X264-AMIABLE.mkv]
Input: /home/someUser/torrents/deluge/Magnificent.Movie.2018.INTERNAL.1080p.BluRay.X264-AMIABLE/Magnificent.engines.2
018.internal.1080p.bluray.x264-amiable/Magnificent.Movie.2018.INTERNAL.1080p.BluRay.X264-AMIABLE/Magnificent.Movie.2
018.INTERNAL.1080p.BluRay.X264-AMIABLE.mkv
Group: [mov:Magnificent engines 2018] => [Magnificent.Movie.2018.INTERNAL.1080p.BluRay.X264-AMIABLE.mkv]
Rename movies using [TheMovieDB]
Auto-detect movie from context: [/home/someUser/torrents/deluge/Magnificent.Movie.2018.INTERNAL.1080p.BluRay.X26
4-AMIABLE/Magnificent.engines.2018.internal.1080p.bluray.x264-amiable/Magnificent.Movie.2018.INTERNAL.1080p.BluRay.X26
4-AMIABLE/Magnificent.Movie.2018.INTERNAL.1080p.BluRay.X264-AMIABLE.mkv]
Skipped [/home/someUser/torrents/deluge/Magnificent.Movie.2018.INTERNAL.1080p.BluRay.X264-AMIABLE/Magnificent.engines
.2018.internal.1080p.bluray.x264-amiable/Magnificent.Movie.2018.INTERNAL.1080p.BluRay.X264-AMIABLE/Magnificent.Movie
.2018.INTERNAL.1080p.BluRay.X264-AMIABLE.mkv] because [/home/someUser/torrents/deluge/plex/Movies/Magnificent Engi
nes (2018)/Magnificent Movie (2018).mkv] already exists
Processed 0 files
Finished without processing any files
Failure (°_°)
The movie is not replaced although the new version is twice the file size and better bitrate. (I have seen it sucessfully replace TV Shows etc it's not a new script). Where do you think the issue is?

Thanks so much

User avatar
rednoah
The Source
Posts: 16600
Joined: 16 Nov 2011, 08:59
Location: Taipei
Contact:

Re: How does amc define 'better version'?

Post by rednoah » 11 Mar 2019, 03:57

Yes, higher video resolution and higher file size mean "better" so not much that can go wrong here... Strange...


1.
What does sysinfo output say?


2.
What does filebot -mediainfo say if you run it on those files.
:idea: Please read the FAQ and How to Request Help.

tatar0900
Posts: 12
Joined: 10 Oct 2017, 11:17

Re: How does amc define 'better version'?

Post by tatar0900 » 11 Mar 2019, 20:05

sysinfo:

Code: Select all

FileBot 4.8.2 (r5789)
JNA Native: 5.2.2
MediaInfo: 18.05
7-Zip-JBinding: 9.20
Chromaprint: 1.4.2
Extended Attributes: OK
Unicode Filesystem: OK
Script Bundle: 2019-02-26 (r552)
Groovy: 2.5.1
JRE: Java(TM) SE Runtime Environment 10.0.2
JVM: 64-bit Java HotSpot(TM) 64-Bit Server VM
CPU/MEM: 8 Core / 15 GB Max Memory / 35 MB Used Memory
OS: Linux (amd64)
HW: Linux User 4.15.0-46-generic #49-Ubuntu SMP Wed Feb 6 09:33:07 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
DATA: /home/someUser/.filebot
Package: DEB
License: FileBot License P7005903 (Valid-Until: 2020-02-23)
Done ヾ(@⌒ー⌒@)ノ
dumb me has replaced the old file with the new better file last night manually, so cannot locate it right now I am really sorry. Is there a way to force filebot or amc to just check filesize and replace with the bigger one?

Thanks!

User avatar
rednoah
The Source
Posts: 16600
Joined: 16 Nov 2011, 08:59
Location: Taipei
Contact:

Re: How does amc define 'better version'?

Post by rednoah » 12 Mar 2019, 04:32

Well, that's kinda what's supposed to be happening already. There's probably a reason it's not working, but we won't be able to find out without a test case that doesn't work as expected.
:idea: Please read the FAQ and How to Request Help.

tatar0900
Posts: 12
Joined: 10 Oct 2017, 11:17

Re: How does amc define 'better version'?

Post by tatar0900 » 14 Mar 2019, 16:23

I got another example @rednoah. Existing file is 10GB, the new one is 15GB. The old file is not replaced.

existing filebot -mediainfo

Code: Select all

someMovie someThing Returns (2018) [1920x808 x264 5.1 DTS 2:10]
new one

Code: Select all

someMovie.someThing.Returns.2018.1080p.BluRay.DD7.1.x264-iFT [1920x804 x264 5.1 EAC3 2:10]
amc.log

Code: Select all

Run script [fn:amc] at [Thu Mar 14 15:58:08 CET 2019]
Parameter: unsorted = y
Parameter: music = n
Parameter: artwork = y
Parameter: excludeList = .excludes
Parameter: ut_dir = /home/someUser/torrents/deluge/someMovie.someThing.Returns.2018.10
80p.BluRay.DD7.1.x264-iFT
Parameter: ut_kind = multi
Parameter: ut_title = someMovie.someThing.Returns.2018.1080p.BluRay.DD7.1.x264-iFT
Parameter: ut_label = N/A
Parameter: exec = chmod -R 775 /home/someUser/torrents/deluge/
Use excludes: /home/someUser/torrents/deluge/plex/.excludes (2924)
Ignore video extra: /home/someUser/torrents/deluge/someMovie.someThing.Returns.2018.10
80p.BluRay.DD7.1.x264-iFT/Sample.mkv
Input: /home/someUser/torrents/deluge/someMovie.someThing.Returns.2018.1080p.BluRay.DD
7.1.x264-iFT/someMovie.someThing.Returns.2018.1080p.BluRay.DD7.1.x264-iFT.mkv
Group: [mov:mary poppins returns 2018] => [someMovie.someThing.Returns.2018.1080p.BluRa
y.DD7.1.x264-iFT.mkv]
Rename movies using [TheMovieDB]
Skipped [/home/someUser/torrents/deluge/someMovie.someThing.Returns.2018.1080p.BluRay.
DD7.1.x264-iFT/someMovie.someThing.Returns.2018.1080p.BluRay.DD7.1.x264-iFT.mkv] becaus
e [/home/someUser/torrents/deluge/plex/Movies/someMovie someThing Returns (2018)/someMovie
someThing Returns (2018).mkv] already exists
Processed 0 files
Finished without processing any files

User avatar
rednoah
The Source
Posts: 16600
Joined: 16 Nov 2011, 08:59
Location: Taipei
Contact:

Re: How does amc define 'better version'?

Post by rednoah » 14 Mar 2019, 16:35

Well, 1920*808 > 1920*804 so the existing one rules.

Complex systems that try to score everything would be possible, but that would just mean nobody would know what's going on. Older versions used only file size and that wasn't ideal, resolution isn't ideal in this particular case. Inclined to use overall bitrate though just because it's a single number.
:idea: Please read the FAQ and How to Request Help.

tatar0900
Posts: 12
Joined: 10 Oct 2017, 11:17

Re: How does amc define 'better version'?

Post by tatar0900 » 14 Mar 2019, 16:46

Ok, at least we got it figured out that it's the intended behavior.

How about having maybe a flag like --conflict size and/or --conflict bitrate? :)

User avatar
rednoah
The Source
Posts: 16600
Joined: 16 Nov 2011, 08:59
Location: Taipei
Contact:

Re: How does amc define 'better version'?

Post by rednoah » 14 Mar 2019, 17:22

Possible. But need to wait and see what other users report, to see if there's a general use case, or something specific to a very small number of users.
:idea: Please read the FAQ and How to Request Help.

tatar0900
Posts: 12
Joined: 10 Oct 2017, 11:17

Re: How does amc define 'better version'?

Post by tatar0900 » 14 Mar 2019, 21:55

Ok, thank u very much for taking this into consideration

User avatar
rednoah
The Source
Posts: 16600
Joined: 16 Nov 2011, 08:59
Location: Taipei
Contact:

Re: How does amc define 'better version'?

Post by rednoah » 15 Mar 2019, 14:27

I've updated the score for upcoming revisions.

It's now

Code: Select all

video[0].width * video[0].height * bitrate
instead of just

Code: Select all

video[0].width * video[0].height
:idea: Please read the FAQ and How to Request Help.

tatar0900
Posts: 12
Joined: 10 Oct 2017, 11:17

Re: How does amc define 'better version'?

Post by tatar0900 » 16 Mar 2019, 05:39

Wow thank you very much for swift action rednoah!

I’ll wait for next version to be live for this to in effect yes? Or was this already being handled server-side?

User avatar
rednoah
The Source
Posts: 16600
Joined: 16 Nov 2011, 08:59
Location: Taipei
Contact:

Re: How does amc define 'better version'?

Post by rednoah » 16 Mar 2019, 05:54

The latest build already include that change:
https://get.filebot.net/filebot/FileBot_4.8.5/
:idea: Please read the FAQ and How to Request Help.

tatar0900
Posts: 12
Joined: 10 Oct 2017, 11:17

Re: How does amc define 'better version'?

Post by tatar0900 » 16 Mar 2019, 07:09

I swear this will be last I will be bothering you under this thread :)

I downloaded latest amd64.deb file, gave it +rx. installed to ubuntu via sudo apt install ./filebot...deb

However now I get

Code: Select all

[[email protected]]:(36.1Mb)~$ filebot
Error: LinkageError occurred while loading main class net.filebot.Main
        java.lang.UnsupportedClassVersionError: net/filebot/Main has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 54.0
Did I do something wrong? :?

User avatar
rednoah
The Source
Posts: 16600
Joined: 16 Nov 2011, 08:59
Location: Taipei
Contact:

Re: How does amc define 'better version'?

Post by rednoah » 16 Mar 2019, 09:52

The latest *_amd64.deb package requires Java 11. The error message indicates that Java 10 is being used.
:idea: Please read the FAQ and How to Request Help.

tatar0900
Posts: 12
Joined: 10 Oct 2017, 11:17

Re: How does amc define 'better version'?

Post by tatar0900 » 16 Mar 2019, 11:40

Got it working again! Thanks so much for everything!

Post Reply