Beta is not always showing the illegal character validation dialog

[iainfrerichs]

I ran into a problem with the latest Beta when trying to rename shows where the TMDB TV series name contains illegal characters, in this case trailing periods.

For the first episode, prior to there being a TV series folder already there, I got the illegal character dialog as expected, and after I validated, the series folder and season subfolder were created.

Subsequent episodes in the same season were renamed correctly but without the illegal character dialog being displayed, and the GUI didn't display the 'files renamed' message, or clear the source and destination once the file was renamed.

For an episode in a different season, again no illegal character dialog was displayed, and an error was emitted when it could not create the season subfolder using the pathname including illegal characters. The log below was from when I started filebot from a command prompt - there is a screenshot of the visual error message too. When I started using the launcher and tried the same thing there was an error dialog - screenshot also included:

Code: Select all

D:\Media>d:\FileBot\filebot
MOVE: Access Denied: D:\Media\TV\TV\Paul Merton in Galton & Simpson's...
java.util.concurrent.ExecutionException: java.nio.file.AccessDeniedException: D:\Media\TV\TV\Paul Merton in Galton & Simpson's...
        at net.filebot.ui.rename.RenameAction.lambda$actionPerformed$3(Unknown Source)
        at net.filebot.util.ui.SwingUI.withWaitCursor(Unknown Source)
        at net.filebot.ui.rename.RenameAction.actionPerformed(Unknown Source)
Caused by: java.nio.file.AccessDeniedException: D:\Media\TV\TV\Paul Merton in Galton & Simpson's...
        at net.filebot.util.FileUtilities.resolveDestination(Unknown Source)
        at net.filebot.util.FileUtilities.moveRename(Unknown Source)
        at net.filebot.StandardRenameAction$1.rename(Unknown Source)
        at net.filebot.ui.rename.RenameAction$StandardRenameWorker.call(Unknown Source)
        at net.filebot.ui.rename.RenameAction$StandardRenameWorker.call(Unknown Source)
        at net.filebot.util.ui.ProgressMonitor$1.call(Unknown Source)
        at javafx.graphics/javafx.concurrent.Task$TaskCallable.call(Task.java:1425)

I tried this in the latest revision (r7636) as well as the beta I was using previously (r7608) - both displayed this behaviour.

Using the previous release (Filebot 4.9.1) I do not encounter this problem - it shows the illegal character dialog for each episode.

Sysinfo:

Code: Select all

FileBot 4.9.2 (r7636)
JNA Native: 6.1.0
MediaInfo: 20.03
7-Zip-JBinding: 9.20
Chromaprint: 1.4.3
Extended Attributes: OK
Unicode Filesystem: OK
Script Bundle: 2020-06-05 (r648)
Groovy: 3.0.4
JRE: OpenJDK Runtime Environment 14.0.1
JVM: 64-bit OpenJDK 64-Bit Server VM
CPU/MEM: 8 Core / 8 GB Max Memory / 270 MB Used Memory
OS: Windows 10 (amd64)
STORAGE: NTFS [(C:)] @ 330 GB | NTFS [Warehouse] @ 1.1 TB | NTFS [Music] @ 4.9 TB | NTFS [TV] @ 4.9 TB | NTFS [vero-media] @ 1.4 GB | NTFS [Iain] @ 4.9 TB
DATA: D:\FileBot\data
Package: ZIP
License: FileBot License P8859868 (Valid-Until: 2020-08-11)

Screenshots:
First episode Illegal character dialog: https://snipboard.io/quyZa4.jpg
First episode result: https://snipboard.io/FP0Itg.jpg
Second episode result - file HAS been renamed: https://snipboard.io/lU2Bgp.jpg
Season 2 episode error if I run using filebot.launcher: https://snipboard.io/bitvX2.jpg
Season 2 episode error if I run ffrom command prompt: https://snipboard.io/S1lUkP.jpg

[rednoah]

Good catch. Looks like FileBot will need to account for Windows implicitly ignoring trailing ... in certain circumstances yet throwing errors in others.


Exhibit A

Code: Select all

Get-Item C:\Windows..............


    Directory: C:\


Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----        10-May-20     15:19                Windows

Exhibit B

Code: Select all

Get-Item C:\WTF..............
Get-Item : Cannot find path 'C:\WTF..............' because it does not exist.

This is indeed a "regression" issue. A code change designed for allowing colon in GVFS file paths on Linux inadvertently breaks file paths with trailing dots on Windows.



EDIT:

FileBot r7642 fixes the issue.

[iainfrerichs]

Thanks!

However I installed r7642, and it's now not showing the illegal character dialog when renaming files with a '?' in the new name.

Code: Select all

FileBot 4.9.2 (r7642)
JNA Native: 6.1.0
MediaInfo: 20.03
7-Zip-JBinding: 9.20
Chromaprint: 1.4.3
Extended Attributes: OK
Unicode Filesystem: OK
Script Bundle: 2020-06-05 (r648)
Groovy: 3.0.4
JRE: OpenJDK Runtime Environment 14.0.1
JVM: 64-bit OpenJDK 64-Bit Server VM
CPU/MEM: 8 Core / 8 GB Max Memory / 110 MB Used Memory
OS: Windows 10 (amd64)
STORAGE: NTFS [(C:)] @ 330 GB | NTFS [Warehouse] @ 815 GB | NTFS [Music] @ 4.8 TB | NTFS [TV] @ 4.9 TB | NTFS [vero-media] @ 1.6 GB | NTFS [Iain] @ 4.9 TB
DATA: D:\FileBot\data
Package: ZIP
License: FileBot License P8859868 (Valid-Until: 2020-08-11)

https://snipboard.io/u2J3wh.jpg

[rednoah]

Good catch. Fixed with FileBot r7643.