Page 1 of 1

Add more Tags Please

Posted: 28 May 2018, 12:05
by cyberdoggy
It would be really cool in future releases if you could add more tags such as...

Code: Select all

Extended.Cut|Extended|Expanded|Theatrical.Cut|Uncensored|Remastered|Unrated|Uncut|Directors.Cut|Diamond.Edition|Anniversary.Edition|Collectors.Edition|10th.Anniversary.Edition|20th.Anniversary.Edition|25th.Anniversary.Edition|30th.Anniversary.Edition|40th.Anniversary.Edition|50th.Anniversary.Edition|60th.Anniversary.Edition|70th.Anniversary.Edition|75th.Anniversary.Edition|Special.Edition
I know some of them are there already like the extended cut but the Diamond Edition Disneys would be cool! ;)

Re: Add more Tags Please

Posted: 28 May 2018, 12:09
by rednoah
Some of these tags seem oddly specific and seem to apply to only one single specific movie. Among the tags you have proposed, are there any common ones that you see repeatedly?

I'm not inclined to add the the ones that are unique to one specific movie, but you can always match those using String.match(/.../) with your custom pattern.

Re: Add more Tags Please

Posted: 28 May 2018, 18:26
by kim
maybe add

Code: Select all

\d\dth.Anniversary.Edition
a number of diff. movies has this

and "Expanded" ...few has this, but I don't see why not on list... IF locked with Edition

most of the rest are on the list

Code: Select all

# patterns for all video tags
pattern.video.tags: (Extended.|Ultimate.)?(Director.?s|Collector.?s|Theatrical|Ultimate|Final|Extended|Rogue|Special|Despecialized|R.Rated).(Cut|Edition|Version)|Extended|Remastered|Recut|Uncut|Uncensored|Unrated|IMAX

Re: Add more Tags Please

Posted: 29 May 2018, 05:22
by rednoah
Makes sense. I've added the [00th Anniversary Edition, Diamond Edition] patterns to {tags} for the next release.

Re: Add more Tags Please

Posted: 29 May 2018, 18:16
by kim
I think there is an error ?
no ?

Code: Select all

(\\d+th.)?Anniversary
yes ?

Code: Select all

(\d\d+th.)?Anniversary

Re: Add more Tags Please

Posted: 30 May 2018, 05:14
by rednoah
Java Property files interpret \x in special ways, so \\d means \d as far as the actual value is concerned.

\d+ will match anything from 0..99999999 which is fine for me. I don't think I have to limit it to 2 digits here.

Re: Add more Tags Please

Posted: 01 Jul 2018, 08:13
by TonySoprano
is {tags} broken?

Code: Select all

Binding "tags": undefined

Re: Add more Tags Please

Posted: 01 Jul 2018, 08:21
by rednoah
Not that I know of. What's the full file path of the file where {tags} doesn't yield a value? What value(s) did you expect for this file?

Re: Add more Tags Please

Posted: 01 Jul 2018, 08:33
by TonySoprano
it was a file with a DC tag, i overlooked the fact that {tags} doesnt has DC ?

Is there a list of all the values that is included in {tags} ? Or can we create our own list?

Re: Add more Tags Please

Posted: 01 Jul 2018, 08:51
by rednoah
1.
Abbreviations such as DC are indeed not on the list. The current {tags} pattern is this:

Code: Select all

(Extended.|Ultimate.)?(Director.?s|Collector.?s|Theatrical|Ultimate|Final|Extended|Rogue|Special|Diamond|Despecialized|R.Rated|(\\d+th.)?Anniversary).(Cut|Edition|Version)|Extended|Remastered|Recut|Uncut|Uncensored|Unrated|IMAX

2.
You can't change how {tags} works, but you can do anything in your custom format, such as matching custom patterns.

e.g. match "DC" from the filename:

Code: Select all

fn.match(/DC/)
e.g. match any regex pattern:

Code: Select all

fn.match(/Recut|Uncut|Uncensored|Unrated/)