Page 1 of 1

BUG: Filter displaying wrong files and quantity of

Posted: 15 May 2019, 13:54
by stephen147
PLEASE SEE IMAGE BELOW

Code: Select all

FileBot 4.8.5 (r6224)
JNA Native: 5.2.2
MediaInfo: 18.12
7-Zip-JBinding: 9.20
Chromaprint: fpcalc version 1.4.2
Extended Attributes: OK
Unicode Filesystem: OK
Script Bundle: 2019-05-05 (r564)
Groovy: 2.5.6
JRE: OpenJDK Runtime Environment 11.0.2
JVM: 64-bit OpenJDK 64-Bit Server VM
CPU/MEM: 32 Core / 29 GB Max Memory / 53 MB Used Memory
OS: Windows 10 (amd64)
Package: APPX
License: Microsoft Store License
Done ?(?????)?
Image

Re: BUG: Filter displaying wrong files and quantity of

Posted: 15 May 2019, 14:13
by rednoah
1.
The Movie filter in the Types tool checks for a known Movie match in the filename (e.g. Avatar 2009) and does not further limit this to video files. Further restricting this to video files that are also movie matches would be easy, and that change could be made if you make a case for it.

:idea: One of the Movie items is a folder, which likely contains many files, leading to a higher file count.

:idea: Requiring movie / episode items to be video files make sense to me. In your particular case, that would result there not being a movie category at all though, since all folders / non-video files would be excluded.


2.
Any video file could be a movie file really, but FileBot does not further check or cross-reference online every single file name. There's also no special logic to exclude "video files that are extras" from other "video files" and adding something like that makes less sense to me, since video files are video files.

Re: BUG: Filter displaying wrong files and quantity of

Posted: 15 May 2019, 14:28
by stephen147
It is surely a bug when it sisplays 44 files when there's only 3.

1. My case would be that files that are deemed movies by parsing will be displayed in the Movie folder and thus leaving it easier to RMB>Add to rename. Here it's even getting an mp3 which we all know isin't a video format. :lol:

2 .Regards the Video. I'm onboard with what your saying. :)

:!: Is there a setting to enable the full editor by default when replying?

Re: BUG: Filter displaying wrong files and quantity of

Posted: 15 May 2019, 14:34
by rednoah
1.
I'll make it require video files then. That'll ensure there's no mp3 files and no folders being displayed as movie item. By excluding folders, we also ensure that the file count will always match the number of items displayed.


3.
Yes, but that'll just change the Full Editor & Preview button into a Reply button, and either way. The later just forces everyone to open the Full Editor, but there's no option to just display the Full Editor right away for each thread.

Re: BUG: Filter displaying wrong files and quantity of

Posted: 15 May 2019, 14:45
by stephen147
rednoah wrote: 15 May 2019, 14:34 1.
I'll make it require video files then. That'll ensure there's no mp3 files and no folders being displayed as movie item. By excluding folders, we also ensure that the file count will always match the number of items displayed.
Nice one, thanks for that. In my case, the folder count was only 4 including the root folder. :lol:
rednoah wrote: 15 May 2019, 14:34..option to just display the Full Editor right away for each thread.
Okay, would be nice to have in as a user setting.

Re: BUG: Filter displaying wrong files and quantity of

Posted: 15 May 2019, 14:51
by rednoah
If a future version of phpBB supports that, then I'll be happy to upgrade:
https://www.phpbb.com/

Re: BUG: Filter displaying wrong files and quantity of

Posted: 15 May 2019, 15:20
by stephen147
Okay, checked the forum and the best is some sort of extension I believe.
https://www.phpbb.com/community/viewtopic.php?t=2464006

Or there's a setting for phpbb:
ACP/Posting tab/Post settings/Allow Quick reply/No

Which will show the full editor with a preview botton by default:
Image