Page 1 of 1

updated to 4.9.0 and now is in dark mode

Posted: 07 Apr 2020, 21:20
by jpf55
Is there a way to turn off dark mode?

Running MAC OSX 10.13.6 on iMac (27-inch, Mid 2010)

Re: updated to 4.9.0 and now is in dark mode

Posted: 08 Apr 2020, 04:38
by rednoah
If you turn off Dark Mode in macOS, that will turn off Dark Mode in FileBot (might require a restart).


Alternatively, you can force the default System look and feel by setting the corresponding System Properties:
viewtopic.php?t=9827

Code: Select all

filebot -script fn:properties --def net.filebot.theme=System

Re: updated to 4.9.0 and now is in dark mode

Posted: 08 Apr 2020, 15:41
by jpf55
First choice is not available to me, my mac is soooooo old it does not have Dark Mode, I'm running 10.13.6 High Sierra.

Second, I need help finding where and how to change the setting:
I know basically nothing about Java, I looked for System Properties and net.filebot.theme but found nothing in the app Package Content.
Am I looking in the wrong place?
Thanks in advance

Re: updated to 4.9.0 and now is in dark mode

Posted: 08 Apr 2020, 16:56
by rednoah
That depends... How did you install FileBot? What does System Information say?


:idea: Please read How to Request Help.

Re: updated to 4.9.0 and now is in dark mode

Posted: 08 Apr 2020, 17:01
by jpf55
Mac App store

:? Which System Information? I already mentioned Mac OS X 10.13.6 :?:

Re: updated to 4.9.0 and now is in dark mode

Posted: 08 Apr 2020, 17:02
by rednoah
jpf55 wrote: 08 Apr 2020, 17:01 Mac App store
Sorry, in this case you won't be able to set custom system properties.


As for System Information:
rednoah wrote: 31 Jul 2014, 16:40 Include System Information (press F5 and then click the information symbol)

:arrow: I'll disable Dark Mode auto-detection with upcoming releases though, since the current code doesn't work well for all supported versions of macOS.

Re: updated to 4.9.0 and now is in dark mode

Posted: 08 Apr 2020, 17:08
by jpf55
Thank you very much

Re: updated to 4.9.0 and now is in dark mode

Posted: 20 Apr 2020, 13:52
by jpf55
rednoah wrote: 08 Apr 2020, 17:02 :arrow: I'll disable Dark Mode auto-detection with upcoming releases though, since the current code doesn't work well for all supported versions of macOS.
Thank you for 4.9.1, we are back in Easier to read for old folks, NON-Dark mode

Re: updated to 4.9.0 and now is in dark mode

Posted: 27 Apr 2020, 06:49
by rednoah
So I've reviewed the underlying code and it absolutely should work, and I'm inclined to enable auto-detection again for upcoming releases, due to popular demand.


:!: Dark Mode is enabled if and only if AppleInterfaceStyle is explicitly set to Dark, which strongly indicates that you have in fact enabled Dark Mode in some form on your machine.

Code: Select all

    NSString *osxMode = [[NSUserDefaults standardUserDefaults] stringForKey:@"AppleInterfaceStyle"];
    BOOL isDarkMode = (osxMode != nil && [osxMode isEqualToString:@"Dark"]);

    NSString *darkModeEnabledVar = [NSString stringWithFormat:@"-DDarkMode=%s",
                                    (isDarkMode ? "true" : "false")];
    [systemArguments addObject:darkModeEnabledVar];

Did you perhaps check Use dark menu bar and Dock?
https://appsliced.co/ask/how-do-i-turn- ... e-on-a-mac


Please run this code in Groovy Pad and paste the output:

Code: Select all

runScript 'sysinfo'
runScript 'sysenv'

Re: updated to 4.9.0 and now is in dark mode

Posted: 27 Apr 2020, 17:38
by jpf55
Hi,

I read the article you supplied and YES, I do have "Use dark menu bar and Dock" checked as it prevents screen burn-in.

Also, I do not have or know "Groovy Pad"

Hope this helps

Re: updated to 4.9.0 and now is in dark mode

Posted: 27 Apr 2020, 18:21
by rednoah
I guess that would explain why it did default to Dark Mode on your machine.


:arrow: Well, I guess we'll enable Dark Mode by default again with upcoming releases since it technically works correctly. You can always disable it by disabling the corresponding system settings.

Re: updated to 4.9.0 and now is in dark mode

Posted: 27 Apr 2020, 18:59
by jpf55
Hmmm,
I'm confused... again, 4.9.1 fixed the dark mode problem on macOS High Sierra, even if "Use dark menu bar and Dock" is checked.

If I understand correctly, if you enable Dark Mode by default again in future versions, I would have to disable "Use dark menu bar and Dock" in order for FileBot to be light gray again and therefore run the risk of screen burn-in.

Personally, I say 4.9.1 works, don't change it

Thanks

Re: updated to 4.9.0 and now is in dark mode

Posted: 27 Apr 2020, 19:10
by rednoah
Well, 4.9.1 disabled Dark Mode auto-detection because we thought that you're getting Dark Mode even though you've selected Light Mode, with no way of disabling Dark Mode.

However, as it turns out, you did explicitly enable Dark Mode (or whatever it was called back then) and so it's already working correctly, even for older OS versions (it's not a bug, it's a feature), with the possibility of turning it on or off being available via system preferences.


EDIT:

We'll make sure you'll be able to manually configure and force one or another even with the MAS edition.

Re: updated to 4.9.0 and now is in dark mode

Posted: 27 Apr 2020, 19:40
by jpf55
:lol: Thanks for making me laugh and feel old at the same time with (or whatever it was called back then)
I'll have to wait for 4.9.2 to make sure I understand. :oops:
As it stands now, changing "Use dark menu bar and Dock" has no effect on my mac 10.13.6 :?
Thanks again :)

Re: updated to 4.9.0 and now is in dark mode

Posted: 28 Jun 2020, 05:45
by PaleHaunt
I loved dark mode in 4.9.0 and now in 4.9.1, it no longer works for me. Catalina 10.15.5, MacBook Pro 16" 2019 2.6 GHz 6-Core Intel Core i7. Dark mode is set to Dark, not automatic. I'm also an old guy, and likes Dark mode more, so don't listen to the other old dude. Bring it back! hahaha!

Re: updated to 4.9.0 and now is in dark mode

Posted: 28 Jun 2020, 05:51
by rednoah
PaleHaunt wrote: 28 Jun 2020, 05:45 I loved dark mode in 4.9.0 and now in 4.9.1, it no longer works for me. Catalina 10.15.5, MacBook Pro 16" 2019 2.6 GHz 6-Core Intel Core i7. Dark mode is set to Dark, not automatic. I'm also an old guy, and likes Dark mode more, so don't listen to the other old dude. Bring it back! hahaha!
No worries. It'll be back by default again with upcoming releases. :lol:


:idea: In the meanwhile, you can always force one or the other manually (assuming you're not using the Mac App Store edition) like so:
viewtopic.php?t=9827

Re: updated to 4.9.0 and now is in dark mode

Posted: 28 Jun 2020, 17:58
by PaleHaunt
Thanks! So, Where do I enter that code? At a glance, I thought Terminal, but couldn't get that to work.

EDIT: Ahhh, I am using the App Store edition. :?