AMC - Specials

Post by **kim** » 14 May 2016, 14:29

Using AMC CLI - why don't "Specials" get there own sub-folder ?

Now: s01e01 = "Season 01" / file(s)
Now: but s00e01 = file(s) (aka ALL in root dir)
so a Feature Requests for "Specials" = e.g. "Season 00"

Post by **rednoah** » 14 May 2016, 14:44

Are they? Post amc output please.

Post by **kim** » 14 May 2016, 14:58

Input: D:\_DoWnLoaD\Done\tv\Futurama.S00E03.The.Lost.Adventure.mp4
Input: D:\_DoWnLoaD\Done\tv\Futurama.S01E01.Space.Pilot.3000.mp4

Group: [tvs:futurama] => [Futurama.S00E03.The.Lost.Adventure.mp4, Futurama.S01E01.Space.Pilot.3000.mp4]

[MOVE] Rename [D:\_DoWnLoaD\Done\tv\Futurama.S00E03.The.Lost.Adventure.mp4] to [D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Futurama - S00E03 - The Lost Adventure.mp4]
[MOVE] Rename [D:\_DoWnLoaD\Done\tv\Futurama.S01E01.Space.Pilot.3000.mp4] to [D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Season 01\Futurama - S01E01 - Space Pilot 3000.mp4]

Fetching series artwork for [Futurama] to [D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama]

Post by **rednoah** » 14 May 2016, 17:45

Strange. Are you using custom formats?

Post by **kim** » 14 May 2016, 19:12

nope clean "dev:amc" --log-file amc.log --action move --conflict skip --encoding UTF-8 --def artwork=y --def clean=y --def skipExtract=y

same with my custom scripts

if you have a filename you know makes the Specials sub-folder, I will test it ?

Post by **kim** » 14 May 2016, 21:31

Just tried it in GUI "s" (aka season): undefined:

I think because of this:

"season":null,"episode":null,"title":"The Lost Adventure","absolute":null,"special":3

Post by **kim** » 15 May 2016, 13:47

I made it work by doing this:

1st my Format:

{def eSpecial = (sxe =~ '0x').asBoolean(); eSpecial ? 'Season 00' : 'Season '+s.pad(2)}

amc.groovy:

from sxe && sxe.season > 0 ? sxe.season : 1 to sxe && sxe.season > 0 ? sxe.season : 0

in

Code: Select all

fetchSeriesArtworkAndNfo(hasSeasonFolder ? dir.dir : dir, dir, series, sxe && sxe.season > 0 ? sxe.season : 1, false, _args.locale)

but I don't think it's good people need to do this, so pls update filebot code and amc

Post by **rednoah** » 15 May 2016, 15:19

There was bug in the {plex} binding logic. Fixed.

Post by **kim** » 16 May 2016, 11:56

FileBot 4.7 (r3991):
well try using this pre. def format in GUI, I see no change:

{n}/{'Season '+s}/{n} - {s00e00} - {t}

I don't use the "{plex}"

btw:
Documetary --> Documentary

https://github.com/filebot/scripts/comm ... 13aa666e9d

Post by **rednoah** » 16 May 2016, 12:32

Specials are specials, not Season 0 episodes. Your format decides how to deal with specials though.

Look at the example formats on how to do specials yourself:
http://www.filebot.net/forums/viewtopic.php?f=5&t=2

Post by **kim** » 16 May 2016, 13:33

yes, I can make my format "better" like this

{episode.special ? 'Season 00' : 'Season '+s.pad(2)}

BUT if you care to check what I'm writing, you will see the real problem:

fetchSeriesArtworkAndNfo(hasSeasonFolder ? dir.dir : dir, dir, series, sxe && sxe.season > 0 ? sxe.season : 1, false, _args.locale)

do this download the right poster ?
NO, it gets the season 1 NOT the "special"

EDIT:
why you did it

... Anime episodes without season will default to season 01 ...

Post by **kim** » 16 May 2016, 13:41

And if I use your e.g.

{episode.special ? 'Special' : 'Season '+s}

even more problems:
NO Special/season poster
ALL files go in " some show/Special " folder

btw:
this do not do this:

... "Specials" named as Season 0 ...

X:/TV Shows/{n}/{episode.special ? 'Special' : 'Season '+s}/{n} - {episode.special ? 'S00E'+special.pad(2) : s00e00} - {t}

Post by **rednoah** » 16 May 2016, 14:21

1.
Artwork for specials is not supported and has never been. Include logs of current behaviour, and suggest improved behaviour, and I'll have a look. If we're talking about the amc script, and not an episode format, then you need to say so.

2.
Don't argue about the description. Words can be ambiguous. Code cannot. Look at the code.

In this case, "Specials named as Season 0", refers to the filename as you can see by the 'S00E'+special.pad(2) part. It does not refer to the season folder name as is clear by the {episode.special ? 'Special' : 'Season '+s} part.

I guess somehow by using a very specific format, you kinda can trick the artwork script into working the way you want. This is not by design, never been tested, and surprising that it somehow worked for you.

EDIT:

Changed how things work a bit. It should work better now.

Post by **kim** » 16 May 2016, 17:22

As I have said, I made it work (I also made full episode kodi style support for private use, maybe I will share later?)...
but write here to make the "specials" official (own sub folder AND correct artwork with future support from filebot)

"Artwork for specials is not supported and has never been" (how can I know this before you tell me?)
This is what I want (Feature Request)... if season artwork is supported, then why not specials?

This from CLEAN dev:amc (ALL from YOU):

Input: D:\_DoWnLoaD\Done\tv\Futurama.S00E03.The.Lost.Adventure.mp4
Group: [tvs:futurama] => [Futurama.S00E03.The.Lost.Adventure.mp4]
Fetch resource: https://api.thetvdb.com/search/series?name=Futurama
Fetch resource: https://api.thetvdb.com/series/73871
Fetch resource: https://api.thetvdb.com/series/73871/episodes?page=1
Fetch resource: https://api.thetvdb.com/series/73871/episodes?page=2
[MOVE] Rename [D:\_DoWnLoaD\Done\tv\Futurama.S00E03.The.Lost.Adventure.mp4] to [D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Special\Futurama - S00E03 - The Lost Adventure.mp4]

Fetching series artwork for [Futurama] to [D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Special]

Generate Series NFO: Futurama [73871]
Fetch resource: https://api.thetvdb.com/series/73871/im ... ype=poster
Fetching D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Special\poster.jpg => [poster/680x1000, en, 7.6, http://thetvdb.com/banners/posters/73871-2.jpg]
Fetch resource: https://api.thetvdb.com/series/73871/im ... ype=series
Fetching D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Special\banner.jpg => [series/graphical, en, 7.4, http://thetvdb.com/banners/graphical/73871-g15.jpg]
Fetch resource: https://api.thetvdb.com/series/73871/im ... ype=fanart
Fetching D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Special\fanart.jpg => [fanart/graphical/1920x1080, en, 10.0, http://thetvdb.com/banners/fanart/original/73871-35.jpg]
Fetch resource: http://webservice.fanart.tv/v3/tv/73871 ... 2f392c2deb
Fetching D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Special\clearart.png => [hdclearart, en, 3.0, http://assets.fanart.tv/fanart/tv/73871 ... 158474.png]
Fetching D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Special\logo.png => [hdtvlogo, en, 8.0, http://assets.fanart.tv/fanart/tv/73871 ... e8acde.png]
Fetching D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Special\landscape.jpg => [tvthumb, en, 4.0, http://assets.fanart.tv/fanart/tv/73871 ... d27e1f.jpg]

Can you see the problem now ?
do you see ANY files in root of "D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama" ?

now problem to fix:
ONLY the "Futurama - S00E03 - The Lost Adventure.mp4" file need to be in the "Special" folder...
ALL other files in root aka "D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama"

Feature Request:
Artwork for specials support
download "Special" artwork aka "poster" to the "Special" folder
http://thetvdb.com/banners/seasons/73871-0-18.jpg
+special banner.jpg like with normal seasons

like with season 1 now is:
http://thetvdb.com/banners/seasons/73871-1-11.jpg
http://thetvdb.com/banners/seasonswide/73871-1.jpg

"If we're talking about the amc script, and not an episode format, then you need to say so"
you have made it very clear you do not want episode support (I think have the support, but have people make the choice if they want to download or not like with "artwork"), so I ONLY report problems/bugs with out-of-box things... now you know.

Post by **rednoah** » 16 May 2016, 17:41

No worries. I don't use any of this artwork stuff. So things that might seem obvious to you may not be obvious to me.

Here's what I get with your format and latest amc script. Looks good to me:

Code: Select all

[COPY] Rename [_DoWnLoaD/Done/Scaped/TV Shows/Futurama/Special/Futurama - S00E03 - The Lost Adventure.mp4] to [TV Shows/Futurama/Special/Futurama - S00E03 - The Lost Adventure.mp4]
Processed 1 files
Fetching series artwork for [Futurama] to [TV Shows/Futurama/Special]
Generate Series NFO: Futurama [73871]
Fetching TV Shows/Futurama/poster.jpg => [poster/680x1000, en, 7.6, http://thetvdb.com/banners/posters/73871-2.jpg]
Fetching TV Shows/Futurama/banner.jpg => [series/graphical, en, 7.4, http://thetvdb.com/banners/graphical/73871-g15.jpg]
Fetching TV Shows/Futurama/fanart.jpg => [fanart/graphical/1920x1080, en, 10.0, http://thetvdb.com/banners/fanart/original/73871-35.jpg]
Fetching TV Shows/Futurama/Special/poster.jpg => [season/0, en, 10.0, http://thetvdb.com/banners/seasons/73871-0-18.jpg]
Banner not found: TV Shows/Futurama/Special/banner.jpg / seasonwide:seasonwide
Fetching TV Shows/Futurama/clearart.png => [hdclearart, en, 3.0, http://assets.fanart.tv/fanart/tv/73871/hdclearart/futurama-5060424158474.png]
Fetching TV Shows/Futurama/logo.png => [hdtvlogo, en, 8.0, http://assets.fanart.tv/fanart/tv/73871/hdtvlogo/futurama-5053fd2e8acde.png]
Fetching TV Shows/Futurama/landscape.jpg => [tvthumb, en, 4.0, http://assets.fanart.tv/fanart/tv/73871/tvthumb/futurama-4fe54ded27e1f.jpg]
Fetching TV Shows/Futurama/Special/landscape.jpg => [seasonthumb/0, en, 1.0, http://assets.fanart.tv/fanart/tv/73871/seasonthumb/Futurama (0).jpg]

Post by **kim** » 16 May 2016, 20:34

looks ok now, BUT makes a new "problem" (not a big one)

now, it writes to "tvshow.nfo" ("Generate Series NFO: Futurama [73871]") 2 times (if 2 files):

Fetching series artwork for [Futurama] to [D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Season 01]

Generate Series NFO: Futurama [73871]

Fetch resource: https://api.thetvdb.com/series/73871/im ... ype=poster
Fetching D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\poster.jpg => [poster/680x1000, en, 7.6, http://thetvdb.com/banners/posters/73871-2.jpg]

Fetch resource: https://api.thetvdb.com/series/73871/im ... ype=season
Fetching D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Season 01\poster.jpg => [season/1, en, 8.1, http://thetvdb.com/banners/seasons/73871-1-11.jpg]
Fetching D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Season 01\banner.jpg => [seasonwide/1, en, 0.0, http://thetvdb.com/banners/seasonswide/73871-1.jpg]

Fetching series artwork for [Futurama] to [D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Special]

Generate Series NFO: Futurama [73871]

Banner already exists: D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\poster.jpg

and 2 times all the artwork (if not for the "Banner already exists")

Post by **rednoah** » 17 May 2016, 04:58

Artwork is generated per season. If you process two seasons or more at a time it'll update the artwork multiple times, which due to caching and artwork checks doesn't matter. This behaviour has always been the same.

Post by **kim** » 17 May 2016, 11:20

Run AFTER a clear cache AND NO dest. folder or files:

You see all is good until the 2nd "Generate Series NFO: Futurama [73871]"

Using persistent disk cache C:\Program Files\FileBot\cache\0
Fetch resource: https://raw.githubusercontent.com/fileb ... amc.groovy

Run script [dev:amc] at [Tue May 17 13:07:02 CEST 2016]
Parameter: artwork = y
Parameter: clean = y
Parameter: skipExtract = y
Argument: D:\_DoWnLoaD\Done\tv

Input: D:\_DoWnLoaD\Done\tv\Futurama - S00E03 - The Lost Adventure.mp4
Input: D:\_DoWnLoaD\Done\tv\Futurama - S01E01 - Space Pilot 3000.mp4

xattr: [D:\_DoWnLoaD\Done\tv\Futurama - S00E03 - The Lost Adventure.mp4] => [Futurama - Special 3 - The Lost Adventure]
xattr: [D:\_DoWnLoaD\Done\tv\Futurama - S01E01 - Space Pilot 3000.mp4] => [Futurama - 1x01 - Space Pilot 3000]

Group: [tvs:futurama] => [Futurama - S00E03 - The Lost Adventure.mp4, Futurama - S01E01 - Space Pilot 3000.mp4]

Rename episodes using [TheTVDB]

Auto-detected query: [Futurama]
Fetch resource: https://api.thetvdb.com/search/series?name=Futurama
Rank [Futurama] => [Futurama]
Rank [Futurama] => [Futurama]

Fetching episode data for [Futurama]
Fetch resource: https://api.thetvdb.com/series/73871
Fetch resource: https://api.thetvdb.com/series/73871/episodes?page=1
Fetch resource: https://api.thetvdb.com/series/73871/episodes?page=2

[MOVE] Rename [D:\_DoWnLoaD\Done\tv\Futurama - S00E03 - The Lost Adventure.mp4] to [D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Specials\Futurama - S00E03 - The Lost Adventure.mp4]
[MOVE] Rename [D:\_DoWnLoaD\Done\tv\Futurama - S01E01 - Space Pilot 3000.mp4] to [D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Season 01\Futurama - S01E01 - Space Pilot 3000.mp4]
Processed 2 files

Fetching series artwork for [Futurama] to [D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Season 01]

Generate Series NFO: Futurama [73871]

Fetch resource: https://api.thetvdb.com/series/73871/im ... ype=poster
Fetching D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\poster.jpg => [poster/680x1000, en, 7.6, http://thetvdb.com/banners/posters/73871-2.jpg]

Fetch resource: https://api.thetvdb.com/series/73871/im ... ype=series
Fetching D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\banner.jpg => [series/graphical, en, 7.4, http://thetvdb.com/banners/graphical/73871-g15.jpg]

Fetch resource: https://api.thetvdb.com/series/73871/im ... ype=fanart
Fetching D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\fanart.jpg => [fanart/graphical/1920x1080, en, 10.0, http://thetvdb.com/banners/fanart/original/73871-35.jpg]

Fetch resource: https://api.thetvdb.com/series/73871/im ... ype=season
Fetching D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Season 01\poster.jpg => [season/1, en, 8.1, http://thetvdb.com/banners/seasons/73871-1-11.jpg]

Fetch resource: https://api.thetvdb.com/series/73871/im ... seasonwide
Fetching D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Season 01\banner.jpg => [seasonwide/1, en, 0.0, http://thetvdb.com/banners/seasonswide/73871-1.jpg]

Fetch resource: http://webservice.fanart.tv/v3/tv/73871 ... 2f392c2deb
Fetching D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\clearart.png => [hdclearart, en, 3.0, http://assets.fanart.tv/fanart/tv/73871 ... 158474.png]
Fetching D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\logo.png => [hdtvlogo, en, 8.0, http://assets.fanart.tv/fanart/tv/73871 ... e8acde.png]
Fetching D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\landscape.jpg => [tvthumb, en, 4.0, http://assets.fanart.tv/fanart/tv/73871 ... d27e1f.jpg]
Fetching D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Season 01\landscape.jpg => [seasonthumb/1, en, 2.0, http://assets.fanart.tv/fanart/tv/73871 ... 4a62ff.jpg]

Fetching series artwork for [Futurama] to [D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Specials]

Generate Series NFO: Futurama [73871]

Banner already exists: D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\poster.jpg
Banner already exists: D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\banner.jpg
Banner already exists: D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\fanart.jpg

Fetching D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Specials\poster.jpg => [season/0, en, 10.0, http://thetvdb.com/banners/seasons/73871-0-18.jpg]
Banner not found: D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Specials\banner.jpg / seasonwide:seasonwide

Fanart already exists: D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\clearart.png
Fanart already exists: D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\logo.png
Fanart already exists: D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\landscape.jpg

Fetching D:\_DoWnLoaD\Done\Scaped\TV Shows\Futurama\Specials\landscape.jpg => [seasonthumb/0, en, 1.0, http://assets.fanart.tv/fanart/tv/73871 ... b/Futurama (0).jpg]

In other words:
special /season folder stuff = 1 time = OK
root stuff (tvshow.nfo + artwork) = 2 times = BAD

Post by **rednoah** » 17 May 2016, 12:42

How is the second run bad? Nothing in the logs catches my eyes.

Post by **kim** » 17 May 2016, 14:00

there is no problem if 2 diff. tv shows.

if 2+ of same show:
it processes the "root" stuff 2+ times

there is default override on the "tvshow.nfo"... getting is written 2+ times
same with the artwork if not for the file check (Fanart already exists), but still check 2+ times

logs:
extra info/writing because of above

Post by **rednoah** » 17 May 2016, 16:25

Well, typically it's called on one episode at a time, and each time you process one episode (e.g. once a week) you probably want it to update the series nfo file at that time as well (plus that data is in the cache already at this point, so rewriting the nfo doesn't require any extra network requests).

Maybe all that artwork stuff does need a rewrite sometime, but right now I don't care much. I could rewrite that file 1000x times and I'd still take less than the blink of an eye.

If it was redownloading artwork, that would be an issue, since that isn't cached.

Post by **kim** » 17 May 2016, 18:51

"If it was redownloading artwork, that would be an issue, since that isn't cached."
well if set "--conflict override" does this not happen ?

Code: Select all

def fetchSeriesBanner(outputFile, seriesId, bannerType, bannerType2, season, override, locale) {
	if (outputFile.exists() && !override) {
		log.finest "Banner already exists: $outputFile"
		return outputFile
	}

please don't just remove " && !override" you are better then that

Post by **rednoah** » 17 May 2016, 19:17

The amc script has always had override set to false. I've changed that in the artwork.* scripts as well. So no more override. Considering potential for abuse, that option should never have been there in the first place.

Post by **DavidRTurner** » 24 May 2016, 23:51

rednoah wrote:In this case, "Specials named as Season 0", refers to the filename as you can see by the 'S00E'+special.pad(2) part. It does not refer to the season folder name as is clear by the {episode.special ? 'Special' : 'Season '+s} part.

I'm kind of stuck on the new bindings, too, for season/episode...
I also like to name my specials as S00 - but I ALSO include the special's season if it exists.

My old code:

Code: Select all

{episode.special ? 
	('S00E'+special.pad(3)+' (S'+episode.season.pad(2))+'Sp'+special.pad(3)+')' : 
	s00e00}

would give me this:
Doctor Who (2005) S00E061 (S07Sp061) (2005, BBC One, TVDB#78804) -- Pond Life (Part 1)- April [2012-08-27] [Adventure, Drama, Science-Fiction]

but now I'm getting this:
Doctor Who (2005) (2005, BBC One, TVDB#78804) -- Pond Life (Part 1)- April [2012-08-27] [Adventure, Drama, Science-Fiction]

So, it's no issue to get the basic S00E061 to work now, but I'm struggling to get the S07Sp061 added in the current build.
Is the 'season' for the 'specials' now UNavailable, or is it just a tweak I'm not finding?

Post by **rednoah** » 25 May 2016, 06:10

I'd write it like this:

Code: Select all

{allOf{s00e00}{'S'+season.pad(2)+'E'+special.pad(2)}.join(' - ')}

However, it may not work with the latest revision. The new TheTVDB API doesn't support the airs-before/after-season data yet.

AMC - Specials

AMC - Specials

Re: AMC - Specials

Re: AMC - Specials

Re: AMC - Specials

Re: AMC - Specials

Re: AMC - Specials

Re: AMC - Specials

Re: AMC - Specials

Re: AMC - Specials

Re: AMC - Specials

Re: AMC - Specials

Re: AMC - Specials

Re: AMC - Specials

Re: AMC - Specials

Re: AMC - Specials

Re: AMC - Specials

Re: AMC - Specials

Re: AMC - Specials

Re: AMC - Specials

Re: AMC - Specials

Re: AMC - Specials

Re: AMC - Specials

Re: AMC - Specials

Re: AMC - Specials

Re: AMC - Specials