"--conflict auto" argument not working properly?

[phovos]

Hello,

First my "fn:sysinfo"

Code: Select all

$ filebot -script fn:sysinfo
FileBot 4.7.8 (r4846)
JNA Native: 5.1.0
MediaInfo: 0.7.93
p7zip: Version 16.02 (locale=en_US.UTF-8,Utf16=on,HugeFiles=on,32 bits,1 CPU LE)
Chromaprint: 1.4.1
Extended Attributes: OK
Unicode Filesystem: OK
Script Bundle: 2017-03-20 (r484)
Groovy: 2.4.8
JRE: Java(TM) SE Runtime Environment 1.8.0_121
JVM: 32-bit Java HotSpot(TM) Client VM
CPU/MEM: 1 Core / 247 MB Max Memory / 9 MB Used Memory
OS: Linux (arm)
Package: PORTABLE
Data: /home/user/.config/filebot
uname: Linux host 4.9.16-1-ARCH #1 SMP Sun Mar 19 20:16:01 UTC 2017 armv6l GNU/Linux
Done ヾ(＠⌒ー⌒＠)ノ

Everything seems fine.

Now I got a better version of a certain movie and for the first time I tried to use "--conflict auto".

Code: Select all

$ filebot -script fn:amc --output "/home/user/output" --conflict auto --action hardlink -non-strict "/home/user/input/movies" --def "@/home/user/fb/config/amc.args"
Run script [fn:amc] at [Thu Mar 23 20:37:17 EET 2017]
Parameter: subtitles = en,el
Parameter: music = y
Parameter: unsorted = y
Parameter: excludeList = /home/user/fb/config/amc.excludes
Parameter: seriesFormat = Series/{n}/{episode.special ? 'Special' : 'Season '+s.pad(2)}/{n} - {episode.special ? 'S00E'+special.pad(2) : s00e00} - {t.replaceAll(/[`´‘’ʻ]/, /'/).replaceAll(/[!?.]+$/).replacePart(', Part $1')}{'.'+lang}
Argument[0]: /home/user/fb//input/movies
Use excludes: /home/filemedia/fbWork/config/amc.excludes (15)
Input: /home/user/fb/input/movies/My.movie.1996.1080p
Group: [mov:my movie 1996] => [My.movie.1996.1080p]
Rename movies using [TheMovieDB]
Auto-detect movie from context: [/home/user/fb/input/movies/My.movie.1996.1080p]
Failed to read media info: java.lang.IllegalArgumentException: Invalid media file: /home/user/fb/output/Movies/My Movie (1996)/My Movie (1996)/VIDEO_TS/VIDEO_TS.VOB
[AUTO] Unable to delete [/home/user/fb/output/Movies/My Movie (1996)/My Movie (1996)]
Skipped [/home/user/fb/input/movies/My.movie.1996.1080p] because [/home/user/fb/output/Movies/My Movie (1996)/My Movie (1996)] already exists
Processed 0 files
Finished without processing any files
Failure (°_°)

Then after I edit excludes file, I proceed to delete "/home/user/fb/output/Movies/My Movie (1996)" and all its contents by using the same user that I use to run filebot. No issue there so this doesn't seem like it has to do with permissions.

So I run it again:

Code: Select all

filebot -script fn:amc --output "/home/user/output" --conflict auto --action hardlink -non-strict "/home/user/input/movies" --def "@/home/user/fb/config/amc.args"
Run script [fn:amc] at [Thu Mar 23 20:37:17 EET 2017]
Parameter: subtitles = en,el
Parameter: music = y
Parameter: unsorted = y
Parameter: excludeList = /home/user/fb/config/amc.excludes
Parameter: seriesFormat = Series/{n}/{episode.special ? 'Special' : 'Season '+s.pad(2)}/{n} - {episode.special ? 'S00E'+special.pad(2) : s00e00} - {t.replaceAll(/[`´‘’ʻ]/, /'/).replaceAll(/[!?.]+$/).replacePart(', Part $1')}{'.'+lang}
Argument[0]: /home/user/fb//input/movies
Use excludes: /home/filemedia/fbWork/config/amc.excludes (15)
Input: /home/user/fb/input/movies/My.movie.1996.1080p
Group: [mov:my movie 1996] => [My.movie.1996.1080p]
Rename movies using [TheMovieDB]
Auto-detect movie from context: [/home/user/fb/input/movies/My.movie.1996.1080p]
Failed to read media info: java.lang.IllegalArgumentException: Invalid media file: /home/user/fb/output/Movies/My Movie (1996)/My Movie (1996)/VIDEO_TS/VIDEO_TS.VOB
[AUTO] Unable to delete [/home/user/fb/output/Movies/My Movie (1996)/My Movie (1996)]
Skipped [/home/user/fb/input/movies/My.movie.1996.1080p] because [/home/user/fb/output/Movies/My Movie (1996)/My Movie (1996)] already exists
Processed 0 files
Finished without processing any files
Failure (°_°)

Of course I checked again whether the folder was properly deleted and found nothing.

Any advice?

[rednoah]

MediaInfo can't read this file:

Code: Select all

Failed to read media info: java.lang.IllegalArgumentException: Invalid media file: /home/user/fb/output/Movies/My Movie (1996)/My Movie (1996)/VIDEO_TS/VIDEO_TS.VOB

Have you tried other files? The error indicates that this "media file" is less than 64 KB and thus MediaInfo can't get metrics such as resolution.

--conflict auto works for normal video files. I have no idea what happens if you have DVD folders. Is there such a thing as quality in DVD folders? Aren't they all based on the same DVD source?

[phovos]

You are right about the DVD folder and Mediainfo, didn't think about that. And on top of that the new version is a BR folder.

No I haven't tried with other files, didn't have to until now, but I was under the impression that filebot checks size first and then resolution/quality or something along these lines.

In any case it was weird to see the following message:

Code: Select all

[AUTO] Unable to delete [/home/user/fb/output/Movies/My Movie (1996)/My Movie (1996)]

Anyway no big deal. Mostly I was curious about it and thought it might help you catch a bug or two.

[rednoah]

1.
I've never tested DVD vs BR folders.

* FileSize would need special handling to sum up all the file sizes for all the files in the disk folder
* Resolution would need special handling to check each video object (and MediaInfo for each of those may not necessarily be the same)

Resolution comes first. FileSize is only a secondary metric if MediaInfo doesn't work.

If another 2-3 people run into the same limitation, I might have a look. Since I have neither DVD nor BR folders available for testing, I'll shelf this feature request for now.

2.
I suppose it was actually gonna work, for some reason, but folders that contain files can't be deleted:

Code: Select all

[AUTO] Unable to delete [/home/user/fb/output/Movies/My Movie (1996)/My Movie (1996)]

[phovos]

1.
I've never tested DVD vs BR folders.

* FileSize would need special handling to sum up all the file sizes for all the files in the disk folder
* Resolution would need special handling to check each video object (and MediaInfo for each of those may not necessarily be the same)

Resolution comes first. FileSize is only a secondary metric if MediaInfo doesn't work.

If another 2-3 people run into the same limitation, I might have a look. Since I have neither DVD nor BR folders available for testing, I'll shelf this feature request for now.

Absolutely. As I said not a biggie.

2.
I suppose it was actually gonna work, for some reason, but folders that contain files can't be deleted:

Code: Select all

[AUTO] Unable to delete [/home/user/fb/output/Movies/My Movie (1996)/My Movie (1996)]

The strange thing is that this also appears after I have already deleted manually that particular folder and I then try again.