[Feature] Mkv subtitle detection

All your suggestions, requests and ideas for future development
Post Reply
verysofttoiletpaper
Posts: 141
Joined: 05 Jul 2012, 09:44

[Feature] Mkv subtitle detection

Post by verysofttoiletpaper »

Would be very interesting to be able to detect when a mkv container already has subtitles and not download extra subtitles which many times are out of sync and get priority in many players.
User avatar
rednoah
The Source
Posts: 23054
Joined: 16 Nov 2011, 08:59
Location: Taipei
Contact:

Re: [Feature] Mkv subtitle detection

Post by rednoah »

That's pretty easy. Check how AMC forces anime-mode by checking Japnese audio + ASS subtitles.
:idea: Please read the FAQ and How to Request Help.
verysofttoiletpaper
Posts: 141
Joined: 05 Jul 2012, 09:44

Re: [Feature] Mkv subtitle detection

Post by verysofttoiletpaper »

Couldn't the AMC script check if the subtitles already exist in the mkv before downloading more, just like it checks for existing subtitles files?
verysofttoiletpaper
Posts: 141
Joined: 05 Jul 2012, 09:44

Re: [Feature] Mkv subtitle detection

Post by verysofttoiletpaper »

Could you add this improvement to the AMC script?

Thank you :)
verysofttoiletpaper
Posts: 141
Joined: 05 Jul 2012, 09:44

Re: [Feature] Mkv subtitle detection

Post by verysofttoiletpaper »

Has this been forgotten or is there a reason not to add this feature?
User avatar
rednoah
The Source
Posts: 23054
Joined: 16 Nov 2011, 08:59
Location: Taipei
Contact:

Re: [Feature] Mkv subtitle detection

Post by rednoah »

I guess you could easily add this logic to your own custom subtitle script.

Just check with getMediaInfo(...) and see if you get subtitles tracks and if yes just don't pass them along to getMissingSubtitles(...)
:idea: Please read the FAQ and How to Request Help.
User avatar
Ithiel
Power² User
Posts: 204
Joined: 11 Jul 2013, 14:58

Re: [Feature] Mkv subtitle detection

Post by Ithiel »

oohh... kewlies..

Is there a way to feed that into a cmd line for use in the context menu?

i.e. How would I edit something like this to check getMediaInfo() if the mkv already includes subtitles for a (or multiple) specific language(s)?

Code: Select all

cmd /c filebot -get-subtitles \"%1\" -non-strict --lang en --log-file context.log
There can be only one Power² User
User avatar
rednoah
The Source
Posts: 23054
Joined: 16 Nov 2011, 08:59
Location: Taipei
Contact:

Re: [Feature] Mkv subtitle detection

Post by rednoah »

Sorry, that one will need some scripting, either in groovy or cmdline, 1. select all files, 2. filter out files mkv files with embedded subtitles, 3. run -get-subtitles on the remaining files.

Like so:
https://github.com/filebot/scripts/blob ... all.groovy
:idea: Please read the FAQ and How to Request Help.
User avatar
Ithiel
Power² User
Posts: 204
Joined: 11 Jul 2013, 14:58

Re: [Feature] Mkv subtitle detection

Post by Ithiel »

wow.. um... that sounds like an absolute truck-load of work for a very niche requirement, lol.
I think I'll pass on adding that to the context menu for the time being :-P

Hopefully it helps verysofttoiletpaper though.

Side Note: that is one freaking hilarious alias, lol.
There can be only one Power² User
Post Reply