broken exact match in several cases

[sbarnea]

Can anyone tell me why the strict match does not work in this case?

Also I would like to know if there is a way to improve the matching without going to non-strict mode, as this one have too many false matches.

Code: Select all

Auto-detect movie from context: [/Volumes/video/.incoming/movie1/Earth Girls Are Easy (1988).avi]
Exception: [movie1/Earth Girls Are Easy (1988).avi] Multiple options: Force auto-select requires non-strict matching: [Earth Girls Are Easy (1988), Some Girls (1988), Slugs: The Movie (1988), Earth Girls Are Easy (1989), Working Girl (1988), Felix the Cat: The Movie (1988), Earth (1998), Earth (1996), Earth (2007), Bad Girls (1994), Easy (2003), 100 Girls (2000), Fat Girls (2006), Mean Girls (2004), Fast Girls (2012), 5ive Girls (2006), Prison Girls (1972), The Big Easy (1986), Easy Money (1983), These Girls (2005), Easy Wheels (1989), Kiss the Girls (1997), Carry on Girls (1973), Boys and Girls (2000), Cannibal Girls (1973), Uptown Girls (2003), Manson Girls (2014), Easy A (2010), Beautiful Girls (1996), Live Nude Girls (1995), Assault Girls (2009), The Last Girl on Earth (2014), Free and Easy (1930), Material Girls (2006), Calendar Girls (2003), Kick Ass Girls (2013), Girls! Girls! Girls! (1962), Girls on Top (2001), The Final Girls (2015), Very Good Girls (2013), This Girl's Life (2003), Live Nude Girls (2014), Easy Rider (1969), Easy Six (2003), Five Easy Pieces (1970), The Wright Girls (2015), Easy Virtue (1928), Easy Living (1937), Easy Living (1949), Easy Come, Easy Go (1967), Easy Come, Easy Go (1976), Easy Come, Easy Go (1947), For Colored Girls (2010), Girls! Girls! Girls! (2011), The Last Earth Girl Went to Space to Find God (2014), Girls Gone Dead (2012), Guns, Girls and Gambling (2012), Breaking the Girls (2013), All the Real Girls (2003), Girls Against Boys (2012), The Care Bears Movie (1985), Girls Will Be Girls (2003), The Powerpuff Girls (2002), Daddy's Little Girls (2007), The Hard Easy (2006), Girls Just Want to Have Fun (1985), Easy Virtue (2008), Movie 43 (2013), Sweet Movie (1974), Scary Movie (1991), My Little Pony: Equestria Girls (2013), Bee Movie (2007), Silent Movie (1976), The Pirate Movie (1982), Epic Movie (2007), Date Movie (2006), A Goofy Movie (1995), Hot Dog... The Movie (1984), ABBA: The Movie (1977), The Last Movie (1971), American Movie (1999), Scary Movie (2000), Dirty Movie (2011), Blunt Movie (2013), Doug's 1st Movie (1999), Killer Movie (2008), TV: The Movie (2006), Batman: The Movie (1966), The Muppet Movie (1979), Care Bears Movie II: A New Generation (1986), Scary Movie 5 (2013), Scary Movie 3 (2003), Scary Movie 2 (2001), Scary Movie 4 (2006), Extreme Movie (2008), LFO: The Movie (2013), The Sex Movie (2006), The Rugrats Movie (1998), Jetsons: The Movie (1990), The Lego Movie (2014), Disaster Movie (2008), Iris: The Movie (2010), Midnight Movie (2008), Swearnet: The Movie (2014), Yu-Gi-Oh!: The Movie (2004), The Movie Out Here (2012), Twilight Zone: The Movie (1983), Man with a Movie Camera (1929), Easy Rider: The Ride Back (2013), Party Girl (1995), My Little Pony: The Movie (1986), Superhero Movie (2008), The Onion Movie (2008), Valley Girl (1983), Gummy Bear the Movie (2014), Hey Arnold! The Movie (2002), The Lego Movie 2 (2017), Paranormal Movie (2013), Major Movie Star (2008), The Tigger Movie (2000), Best Worst Movie (2009), The Fluffy Movie (2014), Steal This Movie (2000), The Transformers: The Movie (1986), The Brady Bunch Movie (1995), Gregory's Girl (1981), The Garbage Pail Kids Movie (1987), Who's That Girl (1987), Jackass: The Movie (2002), Another Gay Movie (2006), Digimon: The Movie (2000), Piglet's Big Movie (2003), Haggard: The Movie (2003), Pokémon: The Movie 2000 (1999), Cheech and Chong's Next Movie (1980), His Girl Friday (1940), My Girl (1991), Tom and Jerry: The Movie (1992), The Simpsons Movie (2007), Maya the Bee Movie (2014), The Lizzie McGuire Movie (2003), The Kentucky Fried Movie (1977), Pokémon 3: The Movie (2000), Pokémon 4: The Movie (2001), Grown Up Movie Star (2009), Untitled Pets Movie (2016), This Is Not a Movie (2011), Another Dirty Movie (2013), Tank Girl (1995), My Girl 2 (1994), National Lampoon's Movie Madness (1982), Funny Girl (1968), The Harry Hill Movie (2013), Indie Game: The Movie (2012), Kill Buljo: The Movie (2007), Ghost Town: The Movie (2007), Postman Pat: The Movie (2014), Pooh's Heffalump Movie (2005), Untitled Smurfs Movie (2016), The Last Horror Movie (2003), The Hardy Bucks Movie (2013), Video Games: The Movie (2014), Turbo: A Power Rangers Movie (1997), The Greatest Movie Ever Sold (2011), Cheech & Chong's Animated Movie (2013), The Underground Comedy Movie (1999), The Inbetweeners Movie (2011), Not Another Teen Movie (2001), Horrid Henry: The Movie (2011), Cowboy Bebop: The Movie (2001), Nitro Circus: The Movie (2012), El Americano: The Movie (2014), Jesus People: The Movie (2009), Dick Figures: The Movie (2013), Birthday Girl (2001), Girl (1998), The 420 Movie: Mary & Jane (2014), Dirty Sanchez: The Movie (2006), The American Poop Movie (2006), Ladies' Man: A Made Movie (2013), DuckTales the Movie: Treasure of the Lost Lamp (1990), Girl with a Pearl Earring (2003), Hannah Montana: The Movie (2009), Moshi Monsters: The Movie (2013), Pudsey the Dog: The Movie (2014), Phantasmagoria: The Movie (2014), The SpongeBob SquarePants Movie (2004), The Goodbye Girl (1977), Girl 6 (1996), Glee: The 3D Concert Movie (2011), Jonah: A VeggieTales Movie (2002), Tales from the Darkside: The Movie (1990), The Girl Who Played with Fire (2009), I'm in Love with a Church Girl (2013), The Girl Next Door (1999), The Wild Thornberrys Movie (2002), Rugrats in Paris: The Movie (2000), Clifford's Really Big Movie (2004), The Girl (2012), The Girl (2014), Fat Girl (2001), Trailer Park Boys: The Movie (2006), Untitled Shane Dawson Movie (2014), Not Another Celebrity Movie (2013), It's a Boy Girl Thing (2006), Street Fighter II: The Animated Movie (1994), Gone Girl (2014), Call Girl (2012), Sick Girl (2007), My Big Fat Independent Movie (2005), Ultramarines: A Warhammer 40,000 Movie (2010), Dirty Girl (2010), Lars and the Real Girl (2007), Final Girl (2014), Sushi Girl (2012), Marfa Girl (2013), Video Girl (2011), Not Another Not Another Movie (2011), Mighty Morphin Power Rangers: The Movie (1995), Mystery Science Theater 3000: The Movie (1996), Chalet Girl (2011), Jersey Girl (2004), Some Girl(s) (2013), Factory Girl (2006), Weather Girl (2009), See Girl Run (2012), Angry Video Game Nerd: The Movie (2014), Dragon Ball Z: The Movie - The Tree of Might (1990), The Good Girl (2002), The Dead Girl (2006), Girl for Girl (2002), Suburban Girl (2007), Reefer Madness: The Movie Musical (2005), The Ramen Girl (2008), The Final Girl (2010), The Naked Brothers Band: The Movie (2005), Blue Collar Comedy Tour: The Movie (2003), Pokémon: The First Movie - Mewtwo Strikes Back (1998), He's Such a Girl (2009), Tim and Eric's Billion Dollar Movie (2012), The Drawn Together Movie: The Movie! (2010), One False Move (1992), Girl, Interrupted (1999), The Machine Girl (2008), Jay and Silent Bob's Super Groovy Cartoon Movie (2013), The Girl with the Dragon Tattoo (2011), The Girl with the Dragon Tattoo (2009), Getting That Girl (2011), What a Girl Wants (2003), God Help the Girl (2014), The Girl Next Door (2004), The Girl Next Door (2007), The Clockwork Girl (2014), Daddy's Little Girl (2012), Forgetting the Girl (2012), My Best Friend's Girl (2008), The Girl in the Book (2014), The Girl in the Park (2007), Move Over, Darling (1963), The Other Boleyn Girl (2008), Don't Move (2004), Girl Play (2004), Mannequin: On the Move (1991), The Diary of a Teenage Girl (2015), The Girl from the Naked Eye (2012), Girl Model (2011), The Girl Who Invented Kissing (2014), Girl Rising (2013), Kit Kittredge: An American Girl (2008), How She Move (2007), Mauvais sang (1986), Aqua Teen Hunger Force Colon Movie Film for Theaters (2007), Fullmetal Alchemist the Movie: Conqueror of Shamballa (2005), The Pirates Who Don't Do Anything: A VeggieTales Movie (2008), Her Best Move (2007), Girl Most Likely (2012), Girl in Progress (2012), Make Your Move (2013), Girl on a Bicycle (2013), Girl Walks Into a Bar (2011), Max Keeble's Big Move (2001), Jane Austen's Mafia! (1998), Pitch Perfect (2012), Act of Valor (2012), 500 MPH Storm (2013), The Cat's Meow (2001), 7 Khoon Maaf (2011), La mafia uccide solo d'estate (2013), Mafia (2012), Pokémon: Lucario and the Mystery of Mew (2005)]

Here is a 2nd case which seems to be related to the use of double colon in the title (another invalid filename character), which I renamed to " -" (space dash).

Code: Select all

Auto-detect movie from context: [/Volumes/video/.incoming/movie1/Interview with the Vampire - The Vampire Chronicles (1994).mp4]
Exception: [movie1/Interview with the Vampire - The Vampire Chronicles (1994).mp4] Multiple options: Force auto-select requires non-strict matching: [Interview with the Vampire: The Vampire Chronicles (1994), Vampire Hunter (1994), Street Fighter II: The Animated Movie (1994), The Interview (1998), Interview (2000), Interview (2007), Interview with a Vampire (2011), The Vampire (1957), The Vampire (1915), The Vampire (2013), The Vampire Bat (1933), Vampire (1920), The Vampire Lovers (1970), Mark of the Vampire (1935), Lust of the Vampire (1956), Way of the Vampire (2005), Vampire (2011), Vampire (2010), Grave of the Vampire (1972), Blood of the Vampire (1958), Crypt of the Vampire (1964), Fist of the Vampire (2007), The Rape of the Vampire (1968), The Kiss of the Vampire (1963), Embrace of the Vampire (1995), Kingdom of the Vampire (1991), Le vampire (1945), The Vampire Conspiracy (2005), The Return of the Vampire (1944), Shadow of the Vampire (2000), Vampire Cop (1990), Buffy the Vampire Slayer (1992), Vampire Child (1999), Joe Vampire (2013), The Playgirls and the Vampire (1960), The Vampire and the Ballerina (1960), Robo Vampire (1988), Vampire Camp (2012), Vampire Circ

[rednoah]

You can do these files manually. The correct match in this case even gets 1st place so it would work perfectly fine in -non-strict mode.

There is no in-between-strict-non-strict option. It's either very strict, or very optimistic, and you can't have both.

[sbarnea]

I do think that that aiming for 100% match leaves too many matches out, like about 20%.

I've seen many cases where the text is 100% identical (tried with terminal search) and still filebot reports as unmatch. Probably it could be due to due Unicode normalization or lack of it.

Now if you want to do a match on names: you can always get a matching percent, a float between 0 and 1. For ldexample if source file would have an additional space or comma that are different, it would not get 100% but could easily get a 99.37% match ratio.

That's why I am trying to propose the use of a numeric factor for match factors. I did this in the past and there a functions that could return you this value, I am sure we could find one in groovy too.

[rednoah]

That's the point, strict is REALLY strict. FileBot assumes that file names are wrong or misleading, so a good match is only trusted if there is no other potentially good matches.

Granted FileBot doesn't have a special case for already well-named files.

Once you start juggling with finding a perfect threshold you'll be in for a big waste of time, because there is no perfect threshold. And if it's not 100% anymore you have to check through everything manually anyway, so there's no benefit to -non-strict where I've already optimized everything for you.

The options are already sorted by "numeric factor" (as the result by quite a lot of metrics) and as you can see the first match is already the best / correct match.

If you wanna be smart you'll just do a 1st pass strict and trust things to be alright. And then a 2nd pass where you first check all the results. If the files are well-named this will be 100% correct so there will be nothing to do except check through the list and ok everything.

Once you have named everything with FileBot (and FileBot has written xattr metadata) it'll always work in strict mode cause it'll have the metadata.


EDIT: The first case I would do is rename "movie1" to something known like downloads, complete, etc so it's not considered a query.

EDIT 2: Even if I added a special case for already well-named files. It would work for neither of your examples.

Year doesn't match. Bad idea to be lenient about the year in strict mode.

Code: Select all

Exception: [AMC-TEST/Earth Girls Are Easy (1988).avi] Multiple options: Force auto-select requires non-strict matching: [Earth Girls Are Easy (1989), Earth (1998), Earth (1996), Earth (2007)]

Name doesn't match. Bad idea to assume Substring/Year match is good enough for a strict match.

Code: Select all

Exception: [AMC-TEST/Interview with the Vampire - The Vampire Chronicles (1994).mp4] Multiple options: Force auto-select requires non-strict matching: [Interview with the Vampire (1994), The Interview (1998), Interview (2000), Interview (2007)]

EDIT 3: Fixed this strict mode issue with r2211 (given that movie name and year exactly match the file)