Bug In Subtitle Logic?

[gordian]

Sysinfo:

Code: Select all

FileBot 4.5.6 (r2818)
JNA Native: 4.0.0
MediaInfo: MediaInfoLib - v0.7.69
7-Zip-JBinding: OK
chromaprint-tools: fpcalc version 1.1.0 (fpcalc.exe)
Extended Attributes: OK
Groovy Engine: 2.3.9
JRE: Java(TM) SE Runtime Environment 1.8.0_31
JVM: 32-bit Java HotSpot(TM) Client VM
CPU/MEM: 4 Core / 247 MB Max Memory / 11 MB Used Memory
OS: Windows 7 (x86)

Depending on how one tries to fetch subtitles, Filebot behaves differently.
Not sure if the following is considered a bug or expected behavior.


When trying to fetch subtitles and rename files within a single command, Filebot does not seem to lookup the file by name or by hash (tried with files that Filebot is able to identify correctly and which can be found both by hash and name and others that can only be found by name, always with the same results):

Code: Select all

filebot.cmd -rename "Some\Dir" --output "Some/Other/Dir" --conflict fail -non-strict --db TheTVDB -no-xattr --format "{some}{format}" -get-missing-subtitles -non-strict --lang en --output srt --encoding utf8

Code: Select all

Get [English] subtitles for 1 files
No matching subtitles found: Some\Dir\Some.File.mkv
Rename episodes using [TheTVDB]
Auto-detected query: [Series Name]
Fetching episode data for [Series Name]
Rename [Some\Dir\Some.File] to [Some/Other/Dir/Series.Name.S01E01.Title.720p.BluRay.x264-SomeGroup.mkv]
Processed 1 files

Shortening the query to just get subtitles, Filebot searches both by hash and name (and is, depending on the file, successful):

Code: Select all

filebot.cmd -get-missing-subtitles "Some\Dir" -non-strict --lang en --output srt --encoding utf8

Code: Select all

Get [English] subtitles for 1 files
Looking up subtitles by hash via OpenSubtitles
Looking up subtitles by name via OpenSubtitles
[...]

Would it be possible to make Filebot rename files and search for subtitles by hash and alternatively by name within a single CLI run? Preferably using the same detection logic used for renaming when searching for subtitles by name.

As it sits right now, one sometimes has to have Filebot rename files to something more sensible first before searching for subtitles that can only be found by name.
Example:

Filebot correctly recognizes (via the parent folder) and renames files that are stored like this: Series.Name.S01E01.720p.BluRay.x264-SomeGroup\$Some.Cryptic.File.Name.mkv, but the subtitle routine does not find any matches in this example when searching by name. Does it take the parent folder name into account at all?:

Code: Select all

filebot.cmd -get-missing-subtitles "Some\Dir\Series.Name.S01E01.720p.BluRay.x264-SomeGroup" -non-strict --lang en --output srt --encoding utf8
Get [English] subtitles for 1 files
Looking up subtitles by hash via OpenSubtitles
Looking up subtitles by name via OpenSubtitles
No matching subtitles found: Some\Dir\Series.Name.S01E01.720p.BluRay.x264-SomeGroup\$Some.Cryptic.File.Name.mkv

---

filebot.cmd -rename "Some\Dir\Series.Name.S01E01.720p.BluRay.x264-SomeGroup" --output "Some/Other/Dir" --conflict fail -non-strict --db TheTVDB -no-xattr --format "{some}{format}"
Rename episodes using [TheTVDB]
Auto-detected query: [Series Name]
Fetching episode data for [Series Name]
Rename [Some\Dir\Series.Name.S01E01.720p.BluRay.x264-SomeGroup\$Some.Cryptic.File.Name.mkv] to [Some/Other/Dir/Series.Name.S01E01.Title.720p.BluRay.x264-SomeGroup.mkv]
Processed 1 files

---

filebot.cmd -get-missing-subtitles "Some/Other/Dir/" -non-strict --lang en --output srt --encoding utf8
Get [English] subtitles for 1 files
Looking up subtitles by hash via OpenSubtitles
Looking up subtitles by name via OpenSubtitles
Fetching [Series.Name.S01E01.720p.BluRay.x264-SomeGroup.srt]
Export [Series.Name.S01E01.720p.BluRay.x264-SomeGroup.srt] as: SubRip / UTF-8
Writing [Series.Name.S01E01.720p.BluRay.x264-SomeGroup.srt] to [Series.Name.S01E01.720p.BluRay.x264-SomeGroup.eng.srt]

This is only a minor issue in an otherwise phenomenal application.
Just thought I would bring it up as in my way to contribute


Regards,
gordian

[rednoah]

By specifying --db TheTVDB you're also specifying the subtitles database, i.e. excluding OpenSubtitles which is the only supported subtitle database right now. That can be fixed.