Ability to Configure NFO Output

Any questions? Need some help?
dokuro
Posts: 58
Joined: 01 Sep 2023, 18:45

Re: Ability to Configure NFO Output

Post by dokuro »

This is actually worse than I initially thought. Looking at Star Wars: Clone Wars - S02E01-E05.nfo I can see

Console Output: Select all

  <uniqueid type='tvdb' default='true'>79070</uniqueid>
  <title>Chapter XXI</title>
  <showtitle>Star Wars: Clone Wars</showtitle>
  <season>3</season>
  <episode>1</episode>
  <aired>2005-03-21</aired>
the season 2 episodes are tagged as season 3. This seems like a flaw as the nfo data is not aligned with the actual data of the episodes themselves based on how they have been renamed. When I test the plex alpha build again I'll take a look at this but I suspect the data will be off as these are 3x1 where plex expect it to be 2x1. I know for a fact 1x11 -> 1x20 all was missing the data in plex which is what got be pointed onto this in the first place.

I also wonder what other multi part episodes from other shows could be off due to this.

EDIT: Definately a wider issue beyond multi part episodes. I took a look at Firefly - S01E14 - Objects in Space.nfo (firefly uses tvdb dvd episode ordering ...

Console Output: Select all

<episodedetails>
  <uniqueid type='tvdb' default='true'>297998</uniqueid>
  <title>Objects in Space</title>
  <showtitle>Firefly</showtitle>
  <season>1</season>
  <episode>10</episode>
  <aired>2002-12-13</aired>
  <premiered>2002-12-13</premiered>
  <plot>A bounty hunter named Jubal Early sets his sites on capturing River Tam and manages to sneak aboard the Serenity in deep space.</plot>
</episodedetails>
... and you can see while its named 1x14 the nfo info is 1x10.
User avatar
rednoah
The Source
Posts: 24438
Joined: 16 Nov 2011, 08:59
Location: Taipei
Contact:

Re: Ability to Configure NFO Output

Post by rednoah »

:idea: 1x10 is in fact the correct primary SxE number for TheTVDB Episode ID 297998 - Objects in Space so it's not confusing at all that this SxE number is used for the NFO file. This is intended behaviour, so you always get the same NFO files regardless of your Episode Order preferences that you have originally used.


:?: If you prefer to use the SxE numbers you see in the file name (that are possibly based on a non-primary SxE order) then we can certainly adjust the script to do that. Do you want to do that and run tests?


:idea: Use preferred SxE numbers (and not primary SxE numbers) · filebot/scripts@12cd4d7 implements the requested change in behaviour.
:idea: Please read the FAQ and How to Request Help.
dokuro
Posts: 58
Joined: 01 Sep 2023, 18:45

Re: Ability to Configure NFO Output

Post by dokuro »

Again thanks for your help.

I don't understand why This is intended behaviour, so you always get the same NFO files regardless of your Episode Order preferences that you have originally used would be intentional, however I'm very grateful for you implementing https://github.com/filebot/scripts/comm ... f3769c3aa0, I ran a quick test on Star Wars: Clone Wars - S01E01-E20 and it looks correct now with all 20 listed alongside checking Firefly - S01E14 - Objects in Space which now has 1x14 as per my naming.

Console Output: Select all

<episodedetails>
  <uniqueid type='tvdb' default='true'>297998</uniqueid>
  <title>Objects in Space</title>
  <showtitle>Firefly</showtitle>
  <season>1</season>
  <episode>14</episode>
  <aired>2002-12-13</aired>
  <premiered>2002-12-13</premiered>
  <plot>A bounty hunter named Jubal Early sets his sites on capturing River Tam and manages to sneak aboard the Serenity in deep space.</plot>
</episodedetails>
Again, will need to test this within plex to fully confirm its matched and the data is fully ingested.
dokuro
Posts: 58
Joined: 01 Sep 2023, 18:45

Re: Ability to Configure NFO Output

Post by dokuro »

FYI... if you take a look at this comment https://forums.plex.tv/t/plex-nfo-agent ... /936104/83 and the three comments afterwards you will see that plex has hardcoded the series level nfo to be called tvshow.nfo. Within https://github.com/filebot/scripts/blob ... nfo.groovy (line 88) this is set to be the series name which means plex does not detect it.

I'm now using my own custom groovy script for my specific needs where I changed this to def nfoFile = seriesFolder / 'tvshow.nfo' so I'm not directly requesting you change this but you might want to consider it as others could run into this.
User avatar
rednoah
The Source
Posts: 24438
Joined: 16 Nov 2011, 08:59
Location: Taipei
Contact:

Re: Ability to Configure NFO Output

Post by rednoah »

Makes sense to me. We can enforce the tvshow.nfo / movie.nfo standard naming by default.
:idea: Please read the FAQ and How to Request Help.
dokuro
Posts: 58
Joined: 01 Sep 2023, 18:45

Re: Ability to Configure NFO Output

Post by dokuro »

Okay, thank you. Didn't want to assume in case it effected other users of this nfo export script.

BTW, Has season level nfo ever come up before (season.nfo)? Plex seem to have this under the season folder https://forums.plex.tv/t/plex-nfo-agent ... iew/936104. Shows like https://www.themoviedb.org/tv/66732-str ... gs/seasons have titles and summaries which would be nice to include if it wasn't too difficult. Not critical but might be worth considering.
User avatar
rednoah
The Source
Posts: 24438
Joined: 16 Nov 2011, 08:59
Location: Taipei
Contact:

Re: Ability to Configure NFO Output

Post by rednoah »

Possible, but I've never seen season-level NFO files. Any information could instead be added to the series-level NFO or the episode-level NFO. If Plex devs would provide a season.nfo sample file then I could have a look.

As far as FileBot metadata is concerned, the season title is part of each Episode object, just like the season number and the episode number. The season description (especially for non-default episode groupings) might be a bit tricky since that's not readily available already.

Personally, I'd add the season title to the episode-level NFO, inventing our own new elements / attributes doesn't make sense if nobody is going to read it. Happy to implement whatever works for Plex.
:idea: Please read the FAQ and How to Request Help.
dokuro
Posts: 58
Joined: 01 Sep 2023, 18:45

Re: Ability to Configure NFO Output

Post by dokuro »

This Personally, I'd add the season title to the episode-level NFO certainly seems reasonable. Next time I test the plex build out I'll add this to my tests.
Post Reply