Matching issues with revision r4792

All your suggestions, requests and ideas for future development
Post Reply
User avatar
Sheldon
Posts: 188
Joined: 14 Apr 2014, 14:39

Matching issues with revision r4792

Post by Sheldon »

Hi,

there are some matching issues with the current revision

The command

Code: Select all

filebot -list -- db thetvdb --q Colony --lang en --filter "s>=2 && s<=2 && e>=5 && e<=5 " --format "{n} - {s.pad(2)} - {e.pad(2)} - {t}"	
using revision r4752 leads to
Colony - 02 - 05 - Company Man
(correct matching)

using revision r4792 (and all other revisions after r4752) leads to
The Colony - 02 - 05 - The Abduction
(incorrect matching)

The command

Code: Select all

filebot -list -- db tvmaze --q Colony --lang en --filter "s>=2 && s<=2 && e>=5 && e<=5 " --format "{n} - {s.pad(2)} - {e.pad(2)} - {t}"	
using revision r4792 leads to
Colony - 02 - 05 - Company Man
(correct matching)

The command

Code: Select all

filebot -list -- db tvmaze --q Blackish --lang en --filter "s>=3 && s<=3 && e>=14 && e<=14 " --format "{n} - {s.pad(2)} - {e.pad(2)} - {t}"	
using revision r4792 leads to
The Blacklist - 03 - 14 - Lady Ambrosia
(incorrect matching)

The command

Code: Select all

filebot -list -- db thetvdb --q Blackish --lang en --filter "s>=3 && s<=3 && e>=14 && e<=14 " --format "{n} - {s.pad(2)} - {e.pad(2)} - {t}"	
using revision r4792 leads to
Black-ish - 03 - 14 - The Name Game
(correct matching)

The command

Code: Select all

filebot -list -- db tvmaze --q Black-ish --lang en --filter "s>=3 && s<=3 && e>=14 && e<=14 " --format "{n} - {s.pad(2)} - {e.pad(2)} - {t}"	
using revision r4792 leads to
Black-ish - 03 - 14 - The Name Game
(correct matching)

My sysinfo

Code: Select all

FileBot 4.7.7 (r4792)
JNA Native: 5.1.0
MediaInfo: 0.7.91
7-Zip-JBinding: 9.20
Chromaprint: 1.4.2
Extended Attributes: OK
Unicode Filesystem: OK
Script Bundle: 2017-02-10 (r480)
Groovy: 2.4.8
JRE: Java(TM) SE Runtime Environment 1.8.0_121
JVM: 32-bit Java HotSpot(TM) Client VM
CPU/MEM: 2 Core / 247 MB Max Memory / 12 MB Used Memory
OS: Windows Vista (x86)
Package: PORTABLE
Data: D:\Portable Applications\Platform\PortableApps\FileBot
Please have a look at it!

Kind regards,

Sheldon
User avatar
rednoah
The Source
Posts: 23932
Joined: 16 Nov 2011, 08:59
Location: Taipei
Contact:

Re: Matching issues with revision r4792

Post by rednoah »

The newer revision assumes that the database query will give you the correct result as the first option, instead having FileBot guess which result might be best. This may or may not be what you want on a case by case basis.

At this point I'll consider having -list print all episodes for all matching shows...
:idea: Please read the FAQ and How to Request Help.
User avatar
Sheldon
Posts: 188
Joined: 14 Apr 2014, 14:39

Re: Matching issues with revision r4792

Post by Sheldon »

But "Colony" should first lead to "Colony" and not to "The Colony"..
User avatar
rednoah
The Source
Posts: 23932
Joined: 16 Nov 2011, 08:59
Location: Taipei
Contact:

Re: Matching issues with revision r4792

Post by rednoah »

Nevermind. TheTVDB does return "Colony" as Result #1 but the original order was messed up internally.

Fixed with r4794.
:idea: Please read the FAQ and How to Request Help.
User avatar
Sheldon
Posts: 188
Joined: 14 Apr 2014, 14:39

Re: Matching issues with revision r4792

Post by Sheldon »

With r4794 the matching for Colony on thetvdb is fine.Great! Thanks!

On tvmaze for "Blackish" I still get "The Blacklist" instead of "Black-ish".
Can this be improved?
User avatar
rednoah
The Source
Posts: 23932
Joined: 16 Nov 2011, 08:59
Location: Taipei
Contact:

Re: Matching issues with revision r4792

Post by rednoah »

No, because TVmaze does return "The Blacklist" as Result #1 when searching for "Blackish":
http://api.tvmaze.com/search/shows?q=Blackish


EDIT:

The latest revision allows you to fetch episodes for the Top 5 results via the -non-strict flag, so you can use --filter like this:

Code: Select all

filebot -list --q Blackish --db TVmaze -non-strict --filter "n == /Black-ish/"
:idea: Please read the FAQ and How to Request Help.
Post Reply